[FS-1147] Proteus: Support creating a conversation when remote backends are unavailable#3150
Merged
mdimjasevic merged 24 commits intodevelopfrom Mar 23, 2023
Merged
Conversation
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
fs-1147/create-conv-remote-users
branch
6 times, most recently
from
09a2ee7 to
86fea3f
Compare
- This instance doesn't meet the interface contract made with the client devs, but it is something to start with. The next commit should make it a flat list of qualified user IDs.
- The function creating a group conversation used to return an obsolete created conversation where failed-to-notify users were not removed
mdimjasevic
force-pushed
the
fs-1147/create-conv-remote-users
branch
from
86fea3f to
0adeccf
Compare
elland
reviewed
Mar 22, 2023
| :> "conversations" | ||
| :> ReqBody '[Servant.JSON] NewConv | ||
| :> CreateGroupConversationVerb | ||
| ) |
Contributor
There was a problem hiding this comment.
I think we can re-use the existing handler for this. The response change is additive, so it doesn't break backward compatibility, and removing the DOS vector also applies to the previous handler, since we're not keeping that behaviour for the previous endpoint version.
elland
approved these changes
Mar 22, 2023
Contributor
Author
I did reuse the handler. It's just the return type that is parameterised to fit both the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by https://wearezeta.atlassian.net/browse/FS-1147.
Checklist
changelog.d