Revert "Use openssl instead of tls in federator http2 client"#3148
Merged
Revert "Use openssl instead of tls in federator http2 client"#3148
Conversation
This reverts commit fd78663.
zebot
added
the
ok-to-test
Contributor
|
@smatting , will you make a PR to the Frida release branch too? I can do it if you've got something else lined up. |
akshaymankar
added a commit
that referenced
this pull request
Mar 13, 2023
battermann
pushed a commit
that referenced
this pull request
Mar 15, 2023
akshaymankar
added a commit
that referenced
this pull request
Mar 21, 2023
* Revert "Revert "Use openssl instead of tls in federator http2 client (#3051)" (#3148)" This reverts commit 615404b. * Ensure that when http2 wants n bytes, we give it n bytes `SSL.read ssl n` doesn't always return `n` bytes, so reading data multiple times is necessary. Upstream PR has been made to warn future users: haskell-cryptography/HsOpenSSL#81 * Add changelog * Remove the IORef read buffer as openssl never returns extra bytes * Read from openssl in tail recursion
lepsa
pushed a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
…#3051)" (wireapp#3148) This reverts commit fd78663.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3051
Context https://wearezeta.atlassian.net/browse/FS-1609