Conversation
zebot
added
the
ok-to-test
|
@akshaymankar I know you're opposed to this, but I don't think it's a sustainable situation that we have to run the test suite 2-3 times consistently every time we want to get a PR green. With Please please please say ok! |
|
What process do you imagine around this? When we mark something as pending, how and when does it get addressed? |
same process as now, only we don't disrupt everybody else: somebody picks it up and fixes it as time permits. i've also added a make rule to list pending tests, and a shell variable to run them anyway. the important thing is that we don't set this shell variable on concourse. maybe we can set it in a pipeline where we build release artefacts? |
if you want to pair on this let me know. |
This should make life slightly more bearable for everybody including concourse, while still allowing to run the pending tests locally by changing the definition to `pendingTestCase = testCase`.
Makefile
Outdated
| ./dist/brig-index reset --elasticsearch-index directory_test2 --elasticsearch-server http://localhost:9200 > /dev/null | ||
| @echo "brig-index reset currently does not work, see https://github.com/wireapp/wire-server/pull/3114" | ||
| # ./dist/brig-index reset --elasticsearch-index directory_test --elasticsearch-server http://localhost:9200 > /dev/null | ||
| # ./dist/brig-index reset --elasticsearch-index directory_test2 --elasticsearch-server http://localhost:9200 > /dev/null |
There was a problem hiding this comment.
please rebase on develop; this change should not be necessary anymore.
|
integration tests pass locally. i don't know why concourse doesn't run them on this PR. |
This reverts commit 14ef0f1.
Conflicts: services/federator/test/unit/Test/Federator/Remote.hs
* Add `flakyTestCase` command and use it. This should make life slightly more bearable for everybody including concourse, while still allowing to run the pending tests locally by setting `RUN_FLAKY_TESTS=1`. * Make sanitize-pr faster by only looking at changed files.
* Add `flakyTestCase` command and use it. This should make life slightly more bearable for everybody including concourse, while still allowing to run the pending tests locally by setting `RUN_FLAKY_TESTS=1`. * Make sanitize-pr faster by only looking at changed files.
5 participants
This should make life slightly more bearable for everybody including concourse, while still allowing to run the pending tests locally by changing the definition to
pendingTestCase = testCase.Checklist
changelog.d