nginz: enable unlimited_requests_endpoint for authenticated requests, too

[jschaul]

…quests

The change introduced in #2786 had no effect thus far. With this PR, it should start to have the desired effect.

See also https://github.com/zinfra/cailleach/pull/1574 for context of where this appeared.

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[jschaul]

I think we should get this in before https://github.com/zinfra/cailleach/pull/1574 to more clearly see possible effects.

[akshaymankar]

Looks good. I am slightly confused by the commit message and the PR title: where is rate_limit_unlimited defined? I only see unlimited_requests_endpoint

[jschaul]

Looks good. I am slightly confused by the commit message and the PR title: where is rate_limit_unlimited defined? I only see unlimited_requests_endpoint

Ah thanks, I got the words all tangled up. Changed description and changelog to use the same word as in the actual settings.

[jschaul]

With this PR, the config diff for the assets endpoint is this:

          location ~* ^(/v[0-9]+)?/assets/(.*) {
          # ...
+                      # Note that this endpoint has no rate limit per user for authenticated requests
          # ...

whereas for other authenticated endpoints:

          location ~* ^(/v[0-9]+)?/system/settings$ {
          # ...
+                      limit_req zone=reqs_per_user burst=20;
          # ...

and at the top

-       # Limit by $zauth_user if present and not part of rate limit exemptions
-       limit_req zone=reqs_per_user burst=20;