FS-1530 Suppress federated errors when removing users from conversation#3134
Merged
elland merged 7 commits intowireapp:developfrom Mar 14, 2023
Merged
FS-1530 Suppress federated errors when removing users from conversation#3134elland merged 7 commits intowireapp:developfrom
elland merged 7 commits intowireapp:developfrom
Conversation
elland
approved these changes
Mar 13, 2023
Contributor
|
This seem to have somehow changed the result of the |
Contributor
Author
|
Looks like CI is stuck, and I haven't got authorization to merge into the repo. |
battermann
pushed a commit
that referenced
this pull request
Mar 15, 2023
…on (#3134) * FS-1530: Allow partial success when removing users from conversations * FS-1530 Adding tests for deleting conversations and removing members * FS-1530 Formatting and hlint * Hi CI * HI CI --------- Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> Co-authored-by: Igor Ranieri <igor@elland.me>
lepsa
added a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
…on (wireapp#3134) * FS-1530: Allow partial success when removing users from conversations * FS-1530 Adding tests for deleting conversations and removing members * FS-1530 Formatting and hlint * Hi CI * HI CI --------- Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> Co-authored-by: Igor Ranieri <igor@elland.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.dChanges
Make the following routes fault tolerant of federation members being unavailable, and adding tests to cover this situation. The two routes removing members from conversations are covered by the same test, as they quickly converge on the same code path.