Skip to content

FS-1530 Suppress federated errors when removing users from conversation#3134

Merged
elland merged 7 commits intowireapp:developfrom
lepsa:FS-1530
Mar 14, 2023
Merged

FS-1530 Suppress federated errors when removing users from conversation#3134
elland merged 7 commits intowireapp:developfrom
lepsa:FS-1530

Conversation

@lepsa
Copy link
Contributor

@lepsa lepsa commented Mar 7, 2023

Checklist

  • [:heavy_check_mark:] Add a new entry in an appropriate subdirectory of changelog.d
  • [:heavy_check_mark:] Read and follow the PR guidelines

Changes

Make the following routes fault tolerant of federation members being unavailable, and adding tests to cover this situation. The two routes removing members from conversations are covered by the same test, as they quickly converge on the same code path.

  • DELETE /conversations/{cnv_domain}/{cnv}/members/{usr_domain}/{usr}
  • DELETE /conversations/{cnv}/members/{usr}
  • DELETE /teams/{tid}/conversations/{cid}

@mdimjasevic mdimjasevic added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 8, 2023
@elland
Copy link
Contributor

elland commented Mar 13, 2023

This seem to have somehow changed the result of the "POST /federation/search-users : Found (fulltext)" test to return a lot more users than the test expected. I couldn't reproduce this issue locally yet. Investigating further.

@lepsa
Copy link
Contributor Author

lepsa commented Mar 14, 2023

Looks like CI is stuck, and I haven't got authorization to merge into the repo.

@elland elland merged commit d4426d1 into wireapp:develop Mar 14, 2023
battermann pushed a commit that referenced this pull request Mar 15, 2023
…on (#3134)

* FS-1530: Allow partial success when removing users from conversations

* FS-1530 Adding tests for deleting conversations and removing members

* FS-1530 Formatting and hlint

* Hi CI

* HI CI

---------

Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
Co-authored-by: Igor Ranieri <igor@elland.me>
lepsa added a commit to lepsa/wire-server that referenced this pull request Nov 28, 2023
…on (wireapp#3134)

* FS-1530: Allow partial success when removing users from conversations

* FS-1530 Adding tests for deleting conversations and removing members

* FS-1530 Formatting and hlint

* Hi CI

* HI CI

---------

Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
Co-authored-by: Igor Ranieri <igor@elland.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments