stern: make api version check a unit test#3131
Merged
Conversation
zebot
added
the
ok-to-test
smatting
changed the title
2 tasks
stefanwire
approved these changes
Mar 6, 2023
fisx
reviewed
Mar 7, 2023
| @@ -0,0 +1 @@ | |||
| Remove overly restricte api check | |||
Contributor
There was a problem hiding this comment.
arguably it's overly restrictive to make sure we're running into this early, and not when we have to make the version bump. but that's clearly arguable, yes. :)
lepsa
pushed a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the runtime check introduced #3036 and replaces it with a unit test.
Also the overly restrictive test condition
is replaced with