Conversation
zebot
added
the
ok-to-test
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Great!
I also browsed around in wire-api to see if there are any more endpoints that should be moved to V4, but I couldn't find any.
| element 2 V2, | ||
| element 3 V3 | ||
| element 3 V3, | ||
| element 4 V4 |
There was a problem hiding this comment.
Recently we've had that discussion about using versions in endpoint paths and how we missed a bug because we were not testing what versions get converted to when made a path component. Do you want to add a test for it in Test.Wire.API.Routes.Version?
There was a problem hiding this comment.
What test do you mean?
There was a problem hiding this comment.
In Test.Wire.API.Routes.Version I'd extend the test like so:
testToPathComponent :: Assertion
testToPathComponent = do
"v0" @=? toPathComponent V0
"v1" @=? toPathComponent V1
"v2" @=? toPathComponent V2
"v3" @=? toPathComponent V3
"v4" @=? toPathComponent V4
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Hey, make V4 a development version!
Sorry, I clicked approve, then I realized that |
Ah, right, thanks for catching this. |
pcapriotti
force-pushed
the
pcapriotti/finalise-v3
branch
from
d4d6ae4 to
6ed46a5
Compare
* Add pregenerated v3 swagger * Finalise API v3 * Use v2 for welcome messages in tests * Add CHANGELOG entry * Set v4 as the development version * Update golden tests * Add assertion for v4 to version test * Use v2 welcome in end2end tests
4 participants
This finalises API v3, makes it supported, and introduces a new development API v4. All the new MLS endpoints have been removed from v3 and moved to v4.
Checklist
changelog.d