Merged
Conversation
zebot
added
the
ok-to-test
jschaul
force-pushed
the
brig-schema-fold
branch
from
8428e59 to
da07986
Compare
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit. Should reduce installation and setup time of brig's schema by a few seconds.
The only change this introduced to the end schema (in cassandra.cql) is a value in the
bloom_filter_fp_chancesetting for some tables. 0.1 is the recommended default so a better value for fresh installations; and nothing will change for existing installations anyway. Generally I think it's also not a very important setting overall.Checklist
changelog.d