FS-51 Report unavailable clients for Proteus messages#3097
FS-51 Report unavailable clients for Proteus messages#3097mdimjasevic merged 16 commits intowireapp:developfrom
Conversation
Changing the return types to match the ticket. Adding tests and fixing some logic errors.
elland
added
the
ok-to-test
Rewriting the test, basing it off an existing test that is almost what is needed, and removing the prior test.
…age-sending-errors
…age-sending-errors
lepsa
force-pushed
the
fs-51-proteus-message-sending-errors
branch
from
c46520f to
c1d3b77
Compare
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Overall, this looks good, but there are some parts that are not that easy for me to grasp. It'd be great if we could go over the PR in a call!
| ] | ||
| ) | ||
| ] | ||
| expectedRedundant = expectedFailedToSend |
There was a problem hiding this comment.
Why is deeClient a redundant recipient?
There was a problem hiding this comment.
It is due to other tests expecting redundant clients under similar circumstances. If I add code to filter out users from the redundant field those tests will fail.
There was a problem hiding this comment.
Ok, but I still don't understand why. It would also be beneficial for your understanding to get to the bottom of it.
|
@lepsa , please take a look at the federation chat and the reasoning why this is a breaking API change. I'd be happy to pair with you tomorrow morning (Wednesday) should you need help with splitting an endpoint in |
…age-sending-errors
…age-sending-errors
…age-sending-errors
lepsa
force-pushed
the
fs-51-proteus-message-sending-errors
branch
from
5ce5921 to
f21d92d
Compare
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Apart from moving unit tests into a unit test module, this looks good!
|
Please move the unit tests and then merge. No need to wait for another approval from me. |
…age-sending-errors
* FS-51 Report unavailable clients for Proteus messages Changing the return types to match the ticket. Adding tests and fixing some logic errors. * testing changes. Reworking how failing federators are tested. Rewriting the test, basing it off an existing test that is almost what is needed, and removing the prior test. * FS-51: Adding changes from PR review and more tests * Updating tests * FS-51: Moving unit tests to a better module * FS-51: Formatting and linters * FS-51: Updating nix with generate-local-nix-packages.sh * FS-51: Fixing an error
3 participants
Changing the return types to match the ticket.
Adding tests and fixing some logic errors.
Sending a Proteus message will no longer emit an error when the conversation owning server cannot contact federated servers to retrieve client lists. These unavailable users will be listed in the failed to send field of the response sent back to the client. Federation members that can be contacted will have messages fanned out to them.
Checklist
changelog.d