Split Members into multiple constraints#3093
Merged
stefanwire merged 5 commits intodevelopfrom Feb 17, 2023
Merged
Conversation
pcapriotti
force-pushed
the
pcapriotti/split-member-constraints
branch
from
2d51245 to
c03fa18
Compare
zebot
added
the
ok-to-test
…ember-constraints
mdimjasevic
approved these changes
Feb 17, 2023
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Everything looks fine.
It would be great if you added a changelog; it's a quite big change (in terms of the number of lines).
stefanwire
approved these changes
Feb 17, 2023
pcapriotti
force-pushed
the
pcapriotti/split-member-constraints
branch
from
c03fa18 to
cd5c9e9
Compare
…ember-constraints
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits all Polysemy
Membersconstraints into multipleMemberconstraints. This makes it possible for-Wredundant-constraintsto trigger and flag numerous redundant items.Checklist
changelog.d