[FS-1534] The subconversation non-creator gets a remove proposal when leaving#3085
Merged
mdimjasevic merged 6 commits intomlsfrom Feb 16, 2023
Merged
Conversation
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
fs-1534/subconv-creator-leaver-gets-rm-proposal
branch
3 times, most recently
from
6f80d1e to
3725c80
Compare
mdimjasevic
changed the title
stefanwire
force-pushed
the
fs-1534/subconv-creator-leaver-gets-rm-proposal
branch
from
7e655b0 to
a77c3df
Compare
added 3 commits
February 16, 2023 10:42
…r-leaver-gets-rm-proposal
…r-leaver-gets-rm-proposal
mdimjasevic
deleted the
fs-1534/subconv-creator-leaver-gets-rm-proposal
branch
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reproducing a bug report from the web team, we generalized the test case of a subconversation leaver so it can be tested both for the subconversation creator and a non-creator. In effect, there is one more test case for this piece of application logic.
Tracked by https://wearezeta.atlassian.net/browse/FS-1534.
Checklist
changelog.d