[FS-1534] A subconversation leaver gets a remove proposal#3080
Merged
stefanwire merged 4 commits intomlsfrom Feb 14, 2023
Merged
[FS-1534] A subconversation leaver gets a remove proposal#3080stefanwire merged 4 commits intomlsfrom
stefanwire merged 4 commits intomlsfrom
Conversation
zebot
added
the
ok-to-test
stefanwire
approved these changes
Feb 13, 2023
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug identified in https://wearezeta.atlassian.net/browse/FS-1534. A client leaving a subconversation would get a backend-created remove proposal, while it should not. The fix makes the application logic consistent with the MLS conversation leaving case where the leaving user gets no backend-created proposals.
Checklist
changelog.d