Skip to content

Lower the log level of federator inotify#3056

Merged
pcapriotti merged 4 commits intodevelopfrom
pcapriotti/federator-log
Feb 3, 2023
Merged

Lower the log level of federator inotify#3056
pcapriotti merged 4 commits intodevelopfrom
pcapriotti/federator-log

Conversation

@pcapriotti
Copy link
Contributor

Lower the log level of federator inotify. Now it doesn't spam the console output anymore when running integration tests.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the intention to reduce the number of messages? In other words, what do higher and lower map to when it comes to log levels?

@jschaul
Copy link
Member

jschaul commented Feb 2, 2023

@mdimjasevic the log levels are trace < debug < info < warn < error. Warn is higher than debug. The default for federator is specified in the helm chart defaults, currently Info for CI and deployments; and it's specified as Debug for local integration test runs here. Feel free to also set the log level to Info locally if it's too noisy otherwise.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 2, 2023
@pcapriotti pcapriotti merged commit f6e46c3 into develop Feb 3, 2023
@pcapriotti pcapriotti deleted the pcapriotti/federator-log branch February 3, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments