Skip to content

Helm hook type #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschaul merged 2 commits into from
Feb 2, 2023
Merged

Helm hook type #3049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbdfa29
change helm hook type of test resources which are not Pods
jschaul Feb 1, 2023
876cb35
changelog adjustment
jschaul Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/5-internal/helm-test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
charts: Mark all test resources to be only created while running tests
charts: Mark all service/secret/configmap test resources to be re-created by defining them as helm hooks (#3037, #3049)
3 changes: 2 additions & 1 deletion charts/brig/templates/tests/brig-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: Service
metadata:
name: "brig-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
labels:
app: brig-integration
chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
Expand Down
3 changes: 2 additions & 1 deletion charts/brig/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "brig-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
brig:
Expand Down
3 changes: 2 additions & 1 deletion charts/brig/templates/tests/nginz-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ kind: Service
metadata:
name: nginz-integration-http
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
spec:
type: ClusterIP
ports:
Expand Down
3 changes: 2 additions & 1 deletion charts/brig/templates/tests/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: brig-integration-secrets
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
# These "secrets" are only used in tests and are therefore safe to be stored unencrypted
provider-privatekey.pem: |
Expand Down
3 changes: 2 additions & 1 deletion charts/cargohold/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "cargohold-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
cargohold:
Expand Down
3 changes: 2 additions & 1 deletion charts/federator/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "federator-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
federatorInternal:
Expand Down
3 changes: 2 additions & 1 deletion charts/galley/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "galley-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
galley:
Expand Down
3 changes: 2 additions & 1 deletion charts/galley/templates/tests/galley-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: Service
metadata:
name: "galley-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
labels:
app: galley-integration
chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
Expand Down
3 changes: 2 additions & 1 deletion charts/galley/templates/tests/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: galley-integration-secrets
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
# These "secrets" are only used in tests and are therefore safe to be stored unencrypted
provider-privatekey.pem: |
Expand Down
3 changes: 2 additions & 1 deletion charts/gundeck/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "gundeck-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
gundeck:
Expand Down
3 changes: 2 additions & 1 deletion charts/spar/templates/tests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ kind: ConfigMap
metadata:
name: "spar-integration"
annotations:
"helm.sh/hook": test
"helm.sh/hook": post-install
"helm.sh/hook-delete-policy": before-hook-creation
data:
integration.yaml: |
brig:
Expand Down