Skip to content

Comments

Update spar docs#3038

Merged
fisx merged 27 commits intodevelopfrom
update-spar-docs
Feb 3, 2023
Merged

Update spar docs#3038
fisx merged 27 commits intodevelopfrom
update-spar-docs

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jan 30, 2023

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 30, 2023
@fisx fisx changed the title Cleanup. update spar docs Jan 31, 2023
@fisx fisx changed the title update spar docs Update spar docs Jan 31, 2023
@fisx fisx marked this pull request as ready for review February 3, 2023 11:43

```{contents}
:depth: 2
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurwolf you have used the same idiom in https://raw.githubusercontent.com/wireapp/wire-server/develop/docs/src/understand/single-sign-on/understand/main.md with much better success. what am i doing wrong here?

(it's not important, only solve it if it's easy, otherwise we can keep it as it is now. thanks!)

Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some header start with a lower case letter and some start with upper case. Shouldn't this be consistent?

@fisx
Copy link
Contributor Author

fisx commented Feb 3, 2023

these look very unrelated:

            Exception: Assertions failed:
             2: Nothing === Nothing
            Response was:
            Response {responseStatus = Status {statusCode = 200, statusMessage = "OK"}, responseVersion = HTTP/1.1, responseHeaders = [("Server","nginx"),("Date","Fri, 03 Feb 2023 12:14:43 GMT"),("Content-Type","application/json;charset=utf-8"),("Transfer-Encoding","chunked"),("Connection","keep-alive"),("Content-Encoding","gzip"),("Vary","Accept-Encoding"),("Access-Control-Allow-Credentials","true"),("Access-Control-Expose-Headers","Request-Id, Location"),("Request-Id","6ded12428ea8ea8afd21027b5e8ab84b"),("Strict-Transport-Security","max-age=31536000; preload")], responseBody = Just "{\"access_token\":\"ReuvT9SboLXUyJ1RNP-2Tfh-ZNj4mHlc6o8EQ4qvDGe1s38ccvd4rkt24-HvdIcTPydMmz2ZFt5VC0qVbm8GDw==.v=1.k=1.d=1675426513.t=a.l=.u=62d253c2-284a-46d3-81d5-7f3ff0135687.c=5192778784606608860\",\"expires_in\":30,\"token_type\":\"Bearer\",\"user\":\"62d253c2-284a-46d3-81d5-7f3ff0135687\"}", responseCookieJar = CJ {expose = [Cookie {cookie_name = "zuid", cookie_value = "RQCSsky_WGvY6MchVYFmaFspUFyexu-WYLhvdqMEn2s5Nl1yNBiLpAEBQuGlDnEx8_53_GjpUJDiWYY_4XpCBw==.v=1.k=1.d=1675426601.t=u.l=.u=62d253c2-284a-46d3-81d5-7f3ff0135687.r=38932509", cookie_expiry_time = 2023-02-03 12:16:41 UTC, cookie_domain = "nginz-integration-http.test-c0ioj8sqfzp1.svc.cluster.local", cookie_path = "/access", cookie_creation_time = 2023-02-03 12:14:41.960989055 UTC, cookie_last_access_time = 2023-02-03 12:14:43.961571946 UTC, cookie_persistent = True, cookie_host_only = True, cookie_secure_only = False, cookie_http_only = True}]}, responseClose' = ResponseClose}
            CallStack (from HasCallStack):
              error, called at src/Bilge/Assert.hs:89:5 in bilge-0.22.0-IFn4m2QIat540yRoeFR5fM:Bilge.Assert
              <!!, called at test/integration/API/User/Auth.hs:958:56 in main:API.User.Auth
            Use -p '(!/turn/&&!/user.auth.cookies.limit/)&&/nginz-login-multiple-cookies/' to rerun this test only.
        snd-factor-password-challenge
        new-persistent-cookie:                                                               FAIL
          Exception: Assertions failed:
           2: Nothing === Nothing
          Response was:
          Response {responseStatus = Status {statusCode = 200, statusMessage = "OK"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Fri, 03 Feb 2023 12:14:43 GMT"),("Server","Warp/3.3.21"),("Content-Encoding","gzip"),("Content-Type","application/json;charset=utf-8"),("Vary","Accept-Encoding")], responseBody = Just "{\"access_token\":\"uWQIl5PcRkvKLSwnjG4L2ulx-9nbo9JTd_d0Co7dwGe2GhCazxncBpiEyrQm1159NKEJEsYQVWCyE4kQC2n8Aw==.v=1.k=1.d=1675426513.t=a.l=.u=aec91f10-e887-4db0-b7f0-dd687c816e1a.c=1179824342752512468\",\"expires_in\":30,\"token_type\":\"Bearer\",\"user\":\"aec91f10-e887-4db0-b7f0-dd687c816e1a\"}", responseCookieJar = CJ {expose = [Cookie {cookie_name = "zuid", cookie_value = "Qvt-UfUR1tsFHePZSyjM7l8ShciTrWF5ELXmTBBxlGD_2rAKzo-cjjpilNfNV26Edt2ma_qhY9kLD5capVXcAA==.v=1.k=1.d=1675426601.t=u.l=.u=aec91f10-e887-4db0-b7f0-dd687c816e1a.r=aa98e46f", cookie_expiry_time = 2023-02-03 12:16:41 UTC, cookie_domain = "brig.test-c0ioj8sqfzp1.svc.cluster.local", cookie_path = "/access", cookie_creation_time = 2023-02-03 12:14:41.959326394 UTC, cookie_last_access_time = 2023-02-03 12:14:43.960463672 UTC, cookie_persistent = True, cookie_host_only = True, cookie_secure_only = False, cookie_http_only = True}]}, responseClose' = ResponseClose}
          CallStack (from HasCallStack):
            error, called at src/Bilge/Assert.hs:89:5 in bilge-0.22.0-IFn4m2QIat540yRoeFR5fM:Bilge.Assert
            <!!, called at test/integration/API/User/Auth.hs:958:56 in main:API.User.Auth
          Use -p '(!/turn/&&!/user.auth.cookies.limit/)&&/new-persistent-cookie/' to rerun this test only.
        new-session-cookie:                                                                  OK (2.50s)
        suspend-inactive

fisx and others added 7 commits February 3, 2023 14:27
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
fisx and others added 4 commits February 3, 2023 14:29
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
@fisx
Copy link
Contributor Author

fisx commented Feb 3, 2023

these look very unrelated:

both tests pass locally.

@fisx fisx merged commit 8051138 into develop Feb 3, 2023
@fisx fisx deleted the update-spar-docs branch February 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants