fix conversation list parser in stern#3035
Merged
battermann merged 6 commits intodevelopfrom Jan 31, 2023
Merged
Conversation
zebot
added
the
ok-to-test
fisx
approved these changes
Jan 30, 2023
tools/stern/src/Stern/API.hs
Outdated
| notfs <- Intra.getUserNotifications uid | ||
| consent <- Intra.getUserConsentValue uid | ||
| consentLog <- Intra.getUserConsentLog uid | ||
| consent <- (Intra.getUserConsentValue uid <&> Just) `catchE` \_ -> pure Nothing |
Contributor
There was a problem hiding this comment.
do these catch internal errors as well? do we want that?
Contributor
Author
There was a problem hiding this comment.
I don't know, I just noticed that these fail and make the whole request fail, which is unnecessary, IMO.
Contributor
Author
There was a problem hiding this comment.
made a change, see comment below
| . expect2xx | ||
| ) | ||
| parseResponse (mkError status502 "bad-upstream") r | ||
| unVersioned @'V2 <$> parseResponse (mkError status502 "bad-upstream") r |
Contributor
There was a problem hiding this comment.
this wouldn't have happened if we used servant-client for calling internal api end-points... :)
Contributor
Contributor
Author
|
Internally, stern makes multiple requests, some of which can fail and in this case the error will be shown in the response without making the overall request fail. |
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d