fixup to federator ingress helm chart syntax from the changes in #3002#3034
Merged
fixup to federator ingress helm chart syntax from the changes in #3002#3034
Conversation
jschaul
requested review from
akshaymankar,
mdimjasevic,
pcapriotti and
smatting
zebot
added
the
ok-to-test
Contributor
|
@jschaul , I don't have the context here, but my understanding is that your change is not MLS-specific, so to answer your question, you should merge this to |
smatting
approved these changes
Jan 30, 2023
Contributor
|
I'm merging this to test. I think it's low-risk enough |
Member
Author
Thanks! |
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup to #3002 - at least since that PR was merged develop->mls branch, federator's ingress does not deploy properly on the federation environments anymore concourse logs.
this may fix the problem. Should I make this PR to mls branch? Or to develop, then do a develop->mls merge?
I did not test this fix, just applied the same syntax as in the other working ingress resources.