Discriminate against performAction tags for CallsFed constraints#3030
Merged
smatting merged 2 commits intowireapp:developfrom Jan 27, 2023
Merged
Discriminate against performAction tags for CallsFed constraints#3030smatting merged 2 commits intowireapp:developfrom
smatting merged 2 commits intowireapp:developfrom
Conversation
Contributor
Author
|
@smatting please review |
smatting
approved these changes
Jan 27, 2023
battermann
pushed a commit
that referenced
this pull request
Jan 27, 2023
isovector
added a commit
to isovector/wire-server
that referenced
this pull request
Feb 15, 2023
2 tasks
pcapriotti
pushed a commit
that referenced
this pull request
Feb 23, 2023
* feat: connect to transitive-anns * feat: upgrade transitive-anns to ghc 9.2.5 * feat: first successful test! * feat: upgrade to using ToHasAnnotations * feat: remove CallsFed constraints * chore: remove more CallsFed constraints * chore: update hs pin * doc: add documentation to new magical pieces * feat: remove CallsFed constraints * revert: #3030 * feat: try to make CallsFed more injective * chore: re-remove CallsFed constraints * chore: add plugin to cargohold * fix: brig * chore: use official transitive-anns pin * doc: add changelog * fix: get everything building * chore: hlint * chore: fix hlint * fix nix changes after running ``` ./hack/bin/generate-local-nix-packages.sh ``` --------- Co-authored-by: Stefan Berthold <stefan.berthold@wire.com>
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks against the
ConversationActionTagsingleton in Galley'sperformActionin order to give finer-grained constraints about which federated calls get made.Checklist
changelog.d