Set -Wredundant-constraints and fix the errors#3009
Merged
elland merged 10 commits intowireapp:developfrom Feb 13, 2023
Merged
Conversation
|
|
elland
reviewed
Jan 23, 2023
akshaymankar
added
the
ok-to-test
lepsa
force-pushed
the
code-cleanup-constraints
branch
from
d6b79db to
53eb9f2
Compare
elland
approved these changes
Jan 24, 2023
Disabling the warning in many modules due to HasCallStack or type level checks
lepsa
force-pushed
the
code-cleanup-constraints
branch
from
53eb9f2 to
575ffcd
Compare
lepsa
force-pushed
the
code-cleanup-constraints
branch
from
a4763e5 to
909fc3d
Compare
Contributor
|
@lepsa , let me know if you need help with resolving the merge conflicts. I'll be happy to pair on this either on Tuesday or Wednesday this week. |
elland
reviewed
Feb 13, 2023
|
|
||
| teamContacts :: m [UserId] | ||
| teamContacts = screenMemberList =<< getTeamContacts orig | ||
| teamContacts = screenMemberList <$> getTeamContacts orig |
elland
reviewed
Feb 13, 2023
| import Imports | ||
|
|
||
| serialise :: HasCallStack => NativePush -> UserId -> Transport -> IO (Either Failure LT.Text) | ||
| serialise :: HasCallStack => NativePush -> UserId -> Transport -> Either Failure LT.Text |
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling the redundant constraint warning and cleaning up the resulting errors.
Checklist
changelog.d