Skip to content

internal endpoints swagger (brig, cannon)#3003

Merged
supersven merged 38 commits intodevelopfrom
sventennie/internal-endpoints-swagger
Feb 15, 2023
Merged

internal endpoints swagger (brig, cannon)#3003
supersven merged 38 commits intodevelopfrom
sventennie/internal-endpoints-swagger

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Jan 18, 2023

Swagger docs for internal endpoints. This PR contains swagger docs for brig and cannon. The other Haskell services will follow. (I thought it might be better to reach out for feedback early instead of waiting until this PR gets really big...)

I decided to use schema-profunctor where feasible.

Ticket

Screenshot

image

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@supersven supersven temporarily deployed to cachix January 18, 2023 16:27 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 18, 2023 16:27 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 18, 2023
@supersven supersven temporarily deployed to cachix January 19, 2023 09:59 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 19, 2023 09:59 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 19, 2023 18:32 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 19, 2023 18:32 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 19, 2023 18:39 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 19, 2023 18:39 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 08:27 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 08:27 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 09:18 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 09:19 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 09:40 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 09:40 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:17 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:17 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:46 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:46 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:50 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 13:50 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 14:00 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 20, 2023 14:00 — with GitHub Actions Inactive
@supersven supersven marked this pull request as ready for review January 20, 2023 14:01
@supersven supersven changed the title Sventennie/internal endpoints swagger internal endpoints swagger (brig, cannon) Jan 20, 2023
@supersven supersven temporarily deployed to cachix January 23, 2023 16:50 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 23, 2023 16:50 — with GitHub Actions Inactive
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the relevant links here please?

i'll read the rest of this PR soon!

@supersven supersven force-pushed the sventennie/internal-endpoints-swagger branch from b2d9610 to 7ffb9e9 Compare February 14, 2023 18:11
Comment on lines +163 to +170
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i see. then orphans it is i guess! 👍

@supersven supersven merged commit 607d93e into develop Feb 15, 2023
@supersven supersven deleted the sventennie/internal-endpoints-swagger branch February 15, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments