[REFACTORING] ID tag expand abbreviation to full name#2991
Merged
battermann merged 4 commits intodevelopfrom Jan 17, 2023
Merged
[REFACTORING] ID tag expand abbreviation to full name#2991battermann merged 4 commits intodevelopfrom
battermann merged 4 commits intodevelopfrom
Conversation
battermann
force-pushed
the
battermann/id-tag-refactoring
branch
from
b0fbc7f to
9cacb3a
Compare
zebot
added
the
ok-to-test
elland
reviewed
Jan 16, 2023
elland
reviewed
Jan 16, 2023
elland
suggested changes
Jan 16, 2023
Contributor
elland
left a comment
elland
left a comment
There was a problem hiding this comment.
Some docs got mangled b/c of regex replaces.
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Looks good apart from the comments being attacked by the regex
battermann
force-pushed
the
battermann/id-tag-refactoring
branch
from
10f054d to
53815d5
Compare
elland
approved these changes
Jan 16, 2023
Contributor
|
Love seeing this kind of PR <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d