Skip to content

Comments

[FS-1334] Reset a Subconversation#2956

Merged
mdimjasevic merged 8 commits intomlsfrom
fs-1334/reset-subconversation
Jan 9, 2023
Merged

[FS-1334] Reset a Subconversation#2956
mdimjasevic merged 8 commits intomlsfrom
fs-1334/reset-subconversation

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Dec 28, 2022 •
edited
Loading

Per https://wearezeta.atlassian.net/browse/FS-1334, the PR introduces a DELETE endpoint for resetting a subconversation.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic changed the base branch from develop to mls December 28, 2022 10:30
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 1043f8c to b93d9bb Compare December 28, 2022 11:57
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 11:57 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 11:57 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 28, 2022
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from b93d9bb to 785d60d Compare December 28, 2022 12:37
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 12:37 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 12:37 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 15:14 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 15:14 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from f773212 to 667a6d7 Compare December 28, 2022 15:43
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 15:43 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 28, 2022 15:43 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 667a6d7 to 5b6f0ec Compare January 5, 2023 10:38
@mdimjasevic mdimjasevic temporarily deployed to cachix January 5, 2023 10:38 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 5, 2023 10:38 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 5b6f0ec to 9469fe9 Compare January 6, 2023 10:20
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:20 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:20 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 9469fe9 to 506d48c Compare January 6, 2023 10:40
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:40 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:40 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 506d48c to 121686f Compare January 6, 2023 10:41
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:41 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:41 — with GitHub Actions Inactive
Delete a subconversation
9954198 
- Remove all members
- Delete group ID mapping
- Create a new subconversation with a fresh group ID
- Add group ID mapping for the new one
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from 121686f to 905bb3d Compare January 6, 2023 10:48
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:48 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:48 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:58 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 10:58 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic force-pushed the fs-1334/reset-subconversation branch from ff3d26a to 863853c Compare January 6, 2023 11:06
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 11:06 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 11:06 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 11:10 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix January 6, 2023 11:10 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review January 6, 2023 11:11
@mdimjasevic mdimjasevic mentioned this pull request Jan 6, 2023
Merged
2 tasks
@mdimjasevic mdimjasevic merged commit 9947a5f into mls Jan 9, 2023
@mdimjasevic mdimjasevic deleted the fs-1334/reset-subconversation branch January 9, 2023 10:13
@stefanwire stefanwire mentioned this pull request Jan 17, 2023
Merged
9 tasks
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smatting smatting smatting approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdimjasevic @smatting @zebot