hack/bin/upload-image: Retry despite set -e#2953
Merged
akshaymankar merged 1 commit intodevelopfrom Dec 28, 2022
Merged
Conversation
Executing `"$@"` within first argument of `if` prevents `set -e` from immediately failing the whole script. It could also be written as `while ! "$@"; do ...`, but then getting status of `"$@"` is more complicated as `! "$@"` has status=0 and overwrites the value of `$?`.
zebot
added
the
ok-to-test
mdimjasevic
approved these changes
Dec 28, 2022
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
My Bash skills are rusty, but I'd say the PR is OK.
Member
|
One could also do Which might be more readable (to me). But whatever works, really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing
"$@"within first argument ofifpreventsset -efrom immediately failing the whole script.It could also be written as
while ! "$@"; do ..., but then getting status of"$@"is more complicated as! "$@"has status=0 and overwrites the value of$?.Checklist