Skip to content

Comments

Add federated endpoints to get subconversations#2952

Merged
mdimjasevic merged 10 commits intomlsfrom
FS-901-followup-federated-get
Dec 27, 2022
Merged

Add federated endpoints to get subconversations#2952
mdimjasevic merged 10 commits intomlsfrom
FS-901-followup-federated-get

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Dec 27, 2022

https://wearezeta.atlassian.net/browse/FS-901

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting temporarily deployed to cachix December 27, 2022 09:48 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 09:48 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 27, 2022
@mdimjasevic mdimjasevic force-pushed the FS-901-followup-federated-get branch from 649c126 to 084135f Compare December 27, 2022 10:26
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 10:26 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 10:26 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:37 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:37 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:39 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:39 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:57 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:57 — with GitHub Actions Inactive
@smatting smatting changed the title Add federated get subconversation endpoint Add federated endpoints to get subconversations Dec 27, 2022
@smatting smatting marked this pull request as ready for review December 27, 2022 11:58
@mdimjasevic mdimjasevic force-pushed the FS-901-followup-federated-get branch from ef1aff8 to c834a2e Compare December 27, 2022 14:21
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 14:21 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 14:21 — with GitHub Actions Inactive
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some unused constraints in the SubConversation module. Otherwise this looks good.

@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 15:25 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 15:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants