Conversation
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/api-config
branch
from
a475c8a to
d7f2f21
Compare
smatting
force-pushed
the
pcapriotti/api-config
branch
from
d7f2f21 to
ca479c8
Compare
smatting
changed the title
smatting
changed the title
smatting
changed the title
smatting
force-pushed
the
pcapriotti/api-config
branch
from
ca479c8 to
3252d48
Compare
If .Values.config.settings is not set then the template will render to empty string causing runtime problems. Federation domain is a required paramter. The change in this commit turns the runtime error into a error at template evaluation.
Federation domain is a required parameter for carghold
smatting
force-pushed
the
pcapriotti/api-config
branch
from
a5d397a to
3a78d69
Compare
smatting
reviewed
Jan 5, 2023
Comment on lines
+44
to
+46
| {{- if .maxTotalBytes }} | ||
| maxTotalBytes: {{ .maxTotalBytes }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
This causes this change in the configmap:
before:
maxTotalBytes: 5368709120
after
maxTotalBytes: 5.36870912e+09
This has no effect on the value read by the options parser howerver
smatting
reviewed
Jan 5, 2023
Comment on lines
-46
to
51
| contacts: | ||
| {{ toYaml .contacts | indent 12 }} | ||
| {{- toYaml .contacts | nindent 8 }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
I checked the rendere configmap. It is indented correctly.
smatting
approved these changes
Jan 5, 2023
Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
disabledAPIVersionsoption to all services, which can be used to disable certain versions.See also changes to the documention in this PR.
https://wearezeta.atlassian.net/browse/FS-1046
Checklist
changelog.dAdditional checks
To test the helm charts disable V2 on all services then call a v2 endpoint and assert that response is 404 with a
unsupported-versiontag.