Closed
Conversation
zebot
added
the
ok-to-test
smatting
requested changes
Dec 8, 2022
| 1 -> pure SelfConv | ||
| 2 -> pure One2OneConv | ||
| 3 -> pure ConnectConv | ||
| 4 -> pure GlobalTeamConv |
Contributor
There was a problem hiding this comment.
I think we need to keep this. There are currently already values in the DB with "4". If we don't keep this then processes will crash upon reading
Contributor
|
Could this PR have started off by introducing revert commits of earlier GTC PRs and then making changes on top? That would have made reviewing much easier. |
Contributor
|
Closing this in favor of #2916 which just reverts all PRs. The outcome is Compare to the changes from this branch, which is very different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we can have a clean slate on
developto start the long livedmlsbranch.