Conversation
for global team conversations (adds test case)
zebot
added
the
ok-to-test
smatting
approved these changes
Nov 30, 2022
pcapriotti
reviewed
Nov 30, 2022
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
I still think we should not be fetching the global team conversation unconditionally here, rather check if the ID matches the one of the global team conversation, and only fetch it then. Otherwise we're doing two almost identical queries for each conversation. Am I missing something?
1 task
smatting
added a commit
that referenced
this pull request
Dec 9, 2022
* Revert "[FS-1267] Patch issue with initial commit bundle throwing a global team conversation error (#2887)" This reverts commit 1cc2bd2. * Revert "Commented out GTC for release. (#2879)" This reverts commit 49da310. * Revert "Improve global team conversation handling and self conversation creation error. (#2862)" This reverts commit 381bf7b. * Revert "[FS-926] Create new conversation type for global team conversation (#2753)" This reverts commit c4c9ea2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the weird case where a regular conversation would be mistaken for a GTC, adds a test case against regressions.
Checklist
changelog.d