Revert global team conversations PRs #2862 and #2753#2877
Revert global team conversations PRs #2862 and #2753#2877
Conversation
zebot
added
the
ok-to-test
smatting
changed the title
| repo = "mls-test-cli"; | ||
| sha256 = "sha256-FjgAcYdUr/ZWdQxbck2UEG6NEEQLuz0S4a55hrAxUs4="; | ||
| rev = "82fc148964ef5baa92a90d086fdc61adaa2b5dbf"; | ||
| sha256 = "sha256-/XQ/9oQTPkRqgMzDGRm+Oh9jgkdeDM1vRJ6/wEf2+bY="; |
There was a problem hiding this comment.
@smatting , it seems wrong to revert the version of mls-test-cli to use.
There was a problem hiding this comment.
I guess one of the PRs updated the mls-test-cli tool
| zUser :: UserId -> Request -> Request | ||
| zUser = header "Z-User" . toByteString' | ||
|
|
||
| zClient :: ClientId -> Request -> Request |
There was a problem hiding this comment.
The absence of this is likely to fail integration test compilation.
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Generally it looks good, but I think we can and should keep the latest mls-test-cli tool version used.
| zBot :: UserId -> Request -> Request | ||
| zBot = header "Z-Bot" . toByteString' | ||
|
|
||
| zClient :: ClientId -> Request -> Request |
There was a problem hiding this comment.
Oh, I probably confused that other instance of zClient with this one.
|
|
||
| module Test.Galley.Intra.User where | ||
|
|
||
| -- import Debug.Trace (traceShow) |
There was a problem hiding this comment.
No need to bring this back.
There was a problem hiding this comment.
I'm trying not to make any surgical choices in this PR, just a basic revert. When we re-apply the GTC PRs this line will likely get removed again
|
I'm wondering if it wouldn't be simpler/easier to just disable the endpoints for now? 🤔 |
|
We've decided to just comment out the endpoints for the release instead. |
4 participants
Reverts #2862 and #2753