bullet proof smtp (fix flaky test)#2868
Merged
Conversation
869a934 to
c1e4d5e
Compare
d186de2 to
b319a00
Compare
Co-authored-by: fisx <mf@zerobuzz.net>
Use random sockets (and by this ports) generated by a library. Keep the sockets open while the test runs. (Preventing further race-conditions.)
We don't want to run out of file handles...
b319a00 to
75446ea
Compare
battermann
approved these changes
Dec 21, 2022
Contributor
battermann
left a comment
There was a problem hiding this comment.
LGTM, only nitpicks, feel free to ignore :)
Fix grammar Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Code improvements Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Contributor
Author
@battermann , all "nitpicks" were considered useful. Thanks a lot for them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost the same as #2818, but should fix the test instability by using a different way to create random ports for the test SMTP server (
postie).The solution is inspired by our
MockServer.The approach can be sub-summed as:
bindRandomPortTCPofstreaming-commons. I.e. don't deal with all the traps and pitfalls of primitive Socket handling; let the library do it.Checklist
changelog.d