Conversation
zebot
added
the
ok-to-test
supersven
approved these changes
Nov 21, 2022
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
Additionally, I think it would be good to add links to the direnv and nix websites (https://github.com/wireapp/wire-server/pull/2845/files#diff-0b5ca119d2be595aa307d34512d9679e49186307ef94201e4b3dfa079aa89938R66).
| direnv: error wire-server/docs/.envrc is blocked. Run `direnv allow` to approve its content | ||
| ``` | ||
|
|
||
| Run `direnv allow` to allow the `.envrc` file to modify your environment, and you should then have all the binaries/correct environment needed to build the docs. |
Contributor
There was a problem hiding this comment.
Suggested change
| Run `direnv allow` to allow the `.envrc` file to modify your environment, and you should then have all the binaries/correct environment needed to build the docs. | |
| Run `direnv allow` to allow the `.envrc` file to modify your environment. Then, you should have everything (binaries, environment variables) needed to build the docs. |
Contributor
There was a problem hiding this comment.
Should we mention cachix here as well? Without it set up, direnv allow will take hours to complete.
Contributor
Author
There was a problem hiding this comment.
@elland do you have a link/recommendation of what to say about cachix?
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d