Merged
Conversation
zebot
added
the
ok-to-test
elland
reviewed
Jan 25, 2023
Contributor
elland
left a comment
elland
left a comment
There was a problem hiding this comment.
That was way less daunting that I expected 👍. Someone else should review the Nix side of things.
Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com>
pcapriotti
approved these changes
Jan 25, 2023
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Nice job! Minor comments below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades all of
wire-serverto GHC 9.2.4. Some packages needed to be bumped and forked. Please also review the changes in the forks when reviewing this PR.The commits are organized such that they usually modify only a single package.
Checklist
changelog.d