Conversation
|
wire-server helm charts shouldn't know what prod and staging is. We should make the fact if we want to expose/run swagger-ui configurable via helm values, and set them then accordingly in environment-specific config (cailleach) |
There was a problem hiding this comment.
Now this block is under {{ if not (eq $.Values.nginx_conf.env "prod") }} as well.
Valid point. That would require a general overhaul of charts/nginz to remove the concept of environment, and synchronize merging of that refactoring with new values on our systems. I propose to do such a refactoring in an independent PR. As for staying with the current design, this PR achieves its objective as-is without further configuration changes in other environments. |
this hides https://prod-nginz-https.wire.com/api/swagger-ui/ from prod backends to minimize the attack surface.
it should also hide https://prod-nginz-https.wire.com/swagger-ui/ from prod, which delivers js code needed until we can close https://wearezeta.atlassian.net/browse/BE-529. i haven't figured out how to do that yet. but it's somehow related to this and this.
Checklist
changelog.d