Skip to content

Comments

bump nginx-module-vts from v0.1.15 to v0.2.1#2793

Merged
fisx merged 2 commits intodevelopfrom
bump-nginx-module-vts
Oct 24, 2022
Merged

bump nginx-module-vts from v0.1.15 to v0.2.1#2793
fisx merged 2 commits intodevelopfrom
bump-nginx-module-vts

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 24, 2022

https://wearezeta.atlassian.net/browse/SER-218

upstream changelog: https://github.com/vozlt/nginx-module-vts/blob/v0.2.1/CHANGELOG.md

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx temporarily deployed to cachix October 24, 2022 10:39 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 24, 2022
@fisx fisx marked this pull request as ready for review October 24, 2022 10:41
@fisx
Copy link
Contributor Author

fisx commented Oct 24, 2022

TODO:

  • Somebody (me?) should probably look at the changelog and decide if there is anything we need to be aware of.
  • Make sure CI sees this and is ok with it.

@fisx fisx requested review from flokli and jschaul and removed request for flokli October 24, 2022 10:44
@jschaul jschaul requested a review from flokli October 24, 2022 11:13
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay (pending CI), but perhaps @flokli would like to take a quick look also.

@flokli
Copy link
Contributor

flokli commented Oct 24, 2022

Changelog looks good to me. If it builds, I guess this is fine to bump. If there's any metrics looking different now, or dashboards needing adjustments (but doesn't look like from the changelog), we can follow up.

@fisx fisx temporarily deployed to cachix October 24, 2022 12:19 Inactive
@fisx fisx merged commit cfd288c into develop Oct 24, 2022
@fisx fisx deleted the bump-nginx-module-vts branch October 24, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants