Use locally built schema binaries for db migrations #2791
Merged
akshaymankar merged 3 commits intodevelopfrom Oct 24, 2022
Merged
Use locally built schema binaries for db migrations #2791akshaymankar merged 3 commits intodevelopfrom
akshaymankar merged 3 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
fisx
approved these changes
Oct 24, 2022
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
LGTM, just one small change request.
Makefile
Outdated
Contributor
There was a problem hiding this comment.
can you keep a goal that juts emits a deprecation warning tell you what to call instead? (for both reset and migrate.)
akshaymankar
force-pushed
the
akshaymankar/local-db-migrate
branch
from
646e3e7 to
0b3d170
Compare
Also make sure DB is up to date every time tests are run and not just when DBs are spun up.
akshaymankar
force-pushed
the
akshaymankar/local-db-migrate
branch
from
0b3d170 to
1a36a2e
Compare
akshaymankar
changed the title
elland
pushed a commit
that referenced
this pull request
Oct 24, 2022
* Makefile: Allow db-migrate and db-reset to migrate/reset all keyspaces * Use locally built schema binaries for db migrations Also make sure DB is up to date every time tests are run and not just when DBs are spun up.
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make sure DB is up to date every time tests are run and not just when DBs
are spun up.
This allows us to not rely on the "latest" tag of these docker images and also make spinning up local ephemeral services faster.