Conversation
stephen-smith
approved these changes
Oct 24, 2022
19fe87d to
8a577b9
Compare
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes the
deploy/services-demodirectory, including thedemo.shscript.I think it's not worth the upkeep costs (every service has 3 config files, e.g.
services/brig/brig.integration.yaml,deploy/services-demo/confg/brig.demo.yaml,deploy/services-demo/confg/brig.docker.yaml) since it's largely unused by developers, who can use./services/start-services-only.shas an alterantive for testing purposes just as well.For potential end users that want to run a demo of Wire, a helm-based deployment is much more suitable than
demo.sh.demo.sh --run-backofficewas needed to locally teststern. This PR adds stern to the services automatically spawned bystart-services-only.sh.Files and directories that are symlinking to
deploy/services-demoare copied to their respective sources (find . -xtype lshows that no broken symlinks are created by this PR). .Shell scripts in
deploy/services-demoare moved tohack/bin.All documentation is updated.
Checklist
changelog.d