Skip to content

Comments

Delete services-demo#2789

Merged
smatting merged 7 commits intodevelopfrom
smatting/delete-services-demo
Oct 31, 2022
Merged

Delete services-demo#2789
smatting merged 7 commits intodevelopfrom
smatting/delete-services-demo

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Oct 21, 2022

This PR deletes the deploy/services-demo directory, including the demo.sh script.

I think it's not worth the upkeep costs (every service has 3 config files, e.g. services/brig/brig.integration.yaml, deploy/services-demo/confg/brig.demo.yaml,deploy/services-demo/confg/brig.docker.yaml) since it's largely unused by developers, who can use ./services/start-services-only.sh as an alterantive for testing purposes just as well.
For potential end users that want to run a demo of Wire, a helm-based deployment is much more suitable than demo.sh.
demo.sh --run-backoffice was needed to locally test stern. This PR adds stern to the services automatically spawned by start-services-only.sh.

Files and directories that are symlinking to deploy/services-demo are copied to their respective sources (find . -xtype l shows that no broken symlinks are created by this PR). .
Shell scripts in deploy/services-demo are moved to hack/bin.

All documentation is updated.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting temporarily deployed to cachix October 21, 2022 12:27 Inactive
@smatting smatting temporarily deployed to cachix October 21, 2022 13:11 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 21, 2022
@smatting smatting marked this pull request as ready for review October 21, 2022 13:12
@smatting smatting temporarily deployed to cachix October 21, 2022 13:12 Inactive
@smatting smatting temporarily deployed to cachix October 21, 2022 13:21 Inactive
@smatting smatting force-pushed the smatting/delete-services-demo branch from 19fe87d to 8a577b9 Compare October 31, 2022 15:22
@smatting smatting temporarily deployed to cachix October 31, 2022 15:22 Inactive
@smatting smatting merged commit ff97d20 into develop Oct 31, 2022
@smatting smatting deleted the smatting/delete-services-demo branch October 31, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants