Skip to content

More spar integration tests.#2788

Closed
fisx wants to merge 1 commit intodevelopfrom
more-spar-integration-tests
Closed

More spar integration tests.#2788
fisx wants to merge 1 commit intodevelopfrom
more-spar-integration-tests

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 21, 2022

Trying to reproduce a production issue (and failing so far). The issue is that a team with scim and saml, where the idp has been updated via PUT, does not show users via "scim search by external id" that have not logged in since the idp change.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx temporarily deployed to cachix October 21, 2022 10:36 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 21, 2022
@fisx
Copy link
Contributor Author

fisx commented Oct 21, 2022

First test passes (so I failed to reproduce the production problem); second test fails for the wrong reasons: we currently do not support adding a second idp if there are scim tokens registered with a team.

Failures:

  test-integration/Test/Spar/APISpec.hs:1086:7: 
  1) WireIdPAPIV1.Spar.API, POST /identity-providers, replaces an existing idp, creates new idp, setting old_issuer; sets replaced_by in old idp
       uncaught exception: HttpException
       HttpExceptionRequest Request {
         host                 = "127.0.0.1"
         port                 = 8088
         secure               = False
         requestHeaders       = [("Z-User","bc334447-a4f9-4bfb-81bb-15fc13b7e7a6"),("Content-Type","application/xml")]
         path                 = "/identity-providers/"
         queryString          = "?api_version=v1&replaces=d0cce032-bd72-4ee0-baae-45061207f7a5"
         method               = "POST"
         proxy                = Nothing
         rawBody              = False
         redirectCount        = 10
         responseTimeout      = ResponseTimeoutDefault
         requestVersion       = HTTP/1.1
       }
        (StatusCodeException (Response {responseStatus = Status {statusCode = 400, statusMessage = "more-than-one-idp"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Fri, 21 Oct 2022 10:31:27 GMT"),("Server","Warp/3.3.21"),("Cache-Control","no-cache, no-store"),("Pragma","no-cache")], responseBody = (), responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}) "{\"code\":400,\"label\":\"more-than-one-idp\",\"message\":\"Team can have at most one IdP configured: Teams with SCIM tokens can only have at most one IdP\"}")

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@fisx
Copy link
Contributor Author

fisx commented Aug 11, 2023

deprecated by #3473

@fisx fisx closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants