Skip to content

Comments

Re-lint the codebase#2778

Merged
elland merged 5 commits intodevelopfrom
new-lint
Oct 20, 2022
Merged

Re-lint the codebase#2778
elland merged 5 commits intodevelopfrom
new-lint

Conversation

@elland
Copy link
Contributor

@elland elland commented Oct 20, 2022

Now that we've bumped dev tools versions, hlint is catching more cases.

@elland elland temporarily deployed to cachix October 20, 2022 06:08 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 20, 2022
@elland elland temporarily deployed to cachix October 20, 2022 07:31 Inactive
@elland elland temporarily deployed to cachix October 20, 2022 07:37 Inactive
@elland elland temporarily deployed to cachix October 20, 2022 07:43 Inactive
@elland elland temporarily deployed to cachix October 20, 2022 08:04 Inactive
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@elland elland merged commit 1faa6ed into develop Oct 20, 2022
@elland elland deleted the new-lint branch October 20, 2022 08:55
elland added a commit that referenced this pull request Oct 24, 2022
* New version of hlint is more reliable

* Change file check for -all

* Fixed compilation breaking b/c of operation order?

* Fixed lint script -k true

* Apply lint correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants