nix: Use pkgs.buildEnv for development environment#2776
Merged
akshaymankar merged 4 commits intodevelopfrom Oct 24, 2022
Merged
nix: Use pkgs.buildEnv for development environment#2776akshaymankar merged 4 commits intodevelopfrom
akshaymankar merged 4 commits intodevelopfrom
Conversation
Using haskellPacakges.shellFor directly forced us to use nix-shell which exports too many environment variables. These environment variables cause a lot of problems, specially for people not using NixOS. This change reads buildInputs and nativeBuildInputs for the derivation produced by haskellPacakges.shellFor and adds it to paths of pkgs.buildEnv. To allow cabal to find C dependencies, we also have to export PKG_CONFIG_PATH.
zebot
added
the
ok-to-test
akshaymankar
requested review from
battermann,
elland,
jschaul,
pcapriotti and
smatting
smatting
approved these changes
Oct 20, 2022
Member
Author
|
@pcapriotti @battermann @jschaul can y'all also please test this to see if this also gets rid of your locale problem and other things that we worked around yesterday? |
jschaul
approved these changes
Oct 20, 2022
Member
jschaul
left a comment
jschaul
left a comment
There was a problem hiding this comment.
Much better, my warnings went away.
Member
Author
|
@pcapriotti @battermann in case this works for both of you, please merge the PR. If not, let's look at it on Monday. |
Contributor
Warnings went away, but the problem with signed commits remains. However, the latter does not speak against merging. |
elland
pushed a commit
that referenced
this pull request
Oct 24, 2022
Using haskellPacakges.shellFor directly forced us to use nix-shell which exports too many environment variables. These environment variables cause a lot of problems, specially for people not using NixOS. This change reads buildInputs and nativeBuildInputs for the derivation produced by haskellPacakges.shellFor and adds it to paths of pkgs.buildEnv. To allow cabal to find C dependencies, we also have to export PKG_CONFIG_PATH and LIBRARY_PATH
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using haskellPacakges.shellFor directly forced us to use nix-shell which exports too many environment variables. These environment variables cause a lot of problems, specially for people not using NixOS.
This change reads buildInputs and nativeBuildInputs for the derivation produced by haskellPacakges.shellFor and adds it to paths of pkgs.buildEnv. To allow cabal to find C dependencies, we also have to export PKG_CONFIG_PATH and LIBRARY_PATH
Checklist
changelog.d