FS-1059 Change commit-bundle body type to protobuf format#2773
Merged
FS-1059 Change commit-bundle body type to protobuf format#2773
Conversation
smatting
force-pushed
the
FS-1059-protobuf-commitbundle
branch
from
dff1fa6 to
ce31357
Compare
zebot
added
the
ok-to-test
smatting
force-pushed
the
FS-1059-protobuf-commitbundle
branch
from
fa91041 to
703e81b
Compare
smatting
force-pushed
the
FS-1059-protobuf-commitbundle
branch
from
703e81b to
1c20fd6
Compare
pcapriotti
approved these changes
Oct 21, 2022
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good. Reusing the existing code in Wire.API.ServantProto might be nice, but this is fine too. Regardless, I would maybe change the mime type to application/x-protobuf for consistency with the other endpoints.
| mimeUnrenderMLSWith :: Get a -> LByteString -> Either String a | ||
| mimeUnrenderMLSWith p = first T.unpack . decodeMLSWith p | ||
|
|
||
| data CommitBundleMimeType |
Contributor
There was a problem hiding this comment.
You could use Proto from Wire.API.ServantProto here, instead.
| testCase "validate message signature" testVerifyMLSPlainTextWithKey, | ||
| testCase "create signed remove proposal" testRemoveProposalMessageSignature, | ||
| testCase "parse GroupInfoBundle" testParseGroupInfoBundle | ||
| testCase "parse GroupInfoBundle" testParseGroupInfoBundle -- TODO: remove this also |
Contributor
There was a problem hiding this comment.
Since @smatting is not here to clarify, I'm unsure whether to make this futurework or disable this test. It is currently green for me anyway…
pcapriotti
reviewed
Oct 24, 2022
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the API of the
POST /mls/commit-bundles:application/x-protobufwhich is protobuf serialized object define in wireapp/generic-message-proto@f19b5a1This PR also adds missing tests for the endpoint and removes a superfluous test
Tracked in https://wearezeta.atlassian.net/browse/FS-1059
Checklist
changelog.d