Skip to content

Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers#2772

Merged
jschaul merged 7 commits intodevelopfrom
cacert-fixup
Oct 19, 2022
Merged

Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers#2772
jschaul merged 7 commits intodevelopfrom
cacert-fixup

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented Oct 18, 2022

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@jschaul jschaul temporarily deployed to cachix October 18, 2022 16:15 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 18, 2022
@jschaul jschaul requested a review from akshaymankar October 18, 2022 16:20
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 11:37 Inactive
@jschaul jschaul changed the title cacert-fixup attempt Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers Oct 19, 2022
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 11:39 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 12:36 Inactive
@jschaul jschaul temporarily deployed to cachix October 19, 2022 12:59 Inactive
@jschaul jschaul merged commit 341e58c into develop Oct 19, 2022
@jschaul jschaul deleted the cacert-fixup branch October 19, 2022 14:30
elland pushed a commit that referenced this pull request Oct 24, 2022
… http(s) managers (#2772)

* cacert-fixup attempt

* Use SSL.contextSetDefaultVerifyPaths so we respect SSL_CERT_FILE env var

* Revert "cacert-fixup attempt"

This reverts commit 398cec18b365481640a5206b57305071401a5817.

No need.

* Set SSL_CERT_FILE in all docker images

* Changelog

* Redundant imports

* more redundant imports

Co-authored-by: Akshay Mankar <akshay@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments