[SQSERVICES-1646] Servantify Gundeck#2769
Merged
battermann merged 14 commits intodevelopfrom Oct 25, 2022
Merged
Conversation
battermann
changed the title
zebot
added
the
ok-to-test
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
88aa43f to
371f02a
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
371f02a to
12610e6
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
f392135 to
d6eae9a
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
d6eae9a to
d4f9920
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
d4f9920 to
86a2491
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
7efffae to
50f891f
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
af76d6d to
613bb56
Compare
battermann
force-pushed
the
SQSERVICES-1646-servantify-gundeck
branch
from
ad6f324 to
045177e
Compare
stephen-smith
approved these changes
Oct 24, 2022
fisx
reviewed
Oct 24, 2022
| Maybe ClientId -> | ||
| Maybe (Range 100 10000 Int32) -> | ||
| Gundeck (Maybe Public.QueuedNotificationList) | ||
| paginate uid mbSince mbClient mbSize = do |
Contributor
There was a problem hiding this comment.
is this a copy of services/gundeck/src/Gundeck/Notification.hs? do you want to remove the latter, than?
Contributor
Author
There was a problem hiding this comment.
I don't understand this question. The link seems to point to something unrelated.
Contributor
|
most of my second batch of comments are nit-picks, and you have a green review, but i still have questions. :) if you want my ok, let's talk, but i trust stephen, you can also just merge. |
This was referenced Nov 2, 2022
2 tasks
akshaymankar
added a commit
that referenced
this pull request
Jul 9, 2024
Broken during servantification: #2769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1646
Checklist
changelog.d