Skip to content

Comments

Remove deprecated spar table in cassandra.#2768

Merged
fisx merged 10 commits intodevelopfrom
cleanup-cassandra-schema
Oct 18, 2022
Merged

Remove deprecated spar table in cassandra.#2768
fisx merged 10 commits intodevelopfrom
cleanup-cassandra-schema

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 17, 2022

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx temporarily deployed to cachix October 17, 2022 14:11 Inactive
@fisx fisx temporarily deployed to cachix October 17, 2022 14:11 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 17, 2022
Co-authored-by: Akshay Mankar <akshay@wire.com>
@fisx fisx temporarily deployed to cachix October 17, 2022 18:20 Inactive
@fisx fisx temporarily deployed to cachix October 17, 2022 18:20 Inactive
@fisx fisx temporarily deployed to cachix October 17, 2022 18:43 Inactive
@fisx fisx temporarily deployed to cachix October 17, 2022 18:44 Inactive
fisx added 2 commits October 17, 2022 20:46
...  merge the raw dump and the docs into a documented dump file using
yet another little haskell tool.  :)
@fisx fisx temporarily deployed to cachix October 17, 2022 18:51 Inactive
@fisx fisx temporarily deployed to cachix October 17, 2022 18:51 Inactive
@fisx
Copy link
Contributor Author

fisx commented Oct 17, 2022

Not sure about this at all: 9895a66, but we could do it anyway, then TRUNCATE scim_external_ids instead of dropping it, and keep it around indefinitely. Would make things a lot more robust.

@fisx fisx temporarily deployed to cachix October 18, 2022 09:12 Inactive
@fisx fisx temporarily deployed to cachix October 18, 2022 09:12 Inactive
@fisx
Copy link
Contributor Author

fisx commented Oct 18, 2022

I've removed the migration and left a comment in its place referencing this PR. I am currently building and will add one more commit with the updated cassandra schema.

@fisx fisx requested a review from akshaymankar October 18, 2022 09:13
@fisx fisx temporarily deployed to cachix October 18, 2022 12:13 Inactive
@fisx fisx temporarily deployed to cachix October 18, 2022 12:13 Inactive
@fisx fisx temporarily deployed to cachix October 18, 2022 12:50 Inactive
@fisx fisx merged commit 3b91b3b into develop Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants