Refactor Scim.Scim.UserSpec tests to use composable pieces#2762
Merged
mdimjasevic merged 3 commits intowireapp:developfrom Oct 13, 2022
Merged
Refactor Scim.Scim.UserSpec tests to use composable pieces#2762mdimjasevic merged 3 commits intowireapp:developfrom
mdimjasevic merged 3 commits intowireapp:developfrom
Conversation
Contributor
Author
|
@supersven @fisx please review if you have some time :) |
elland
added
the
ok-to-test
Contributor
Author
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a minor cleanup of some of the tests from #2637, which are delightful examples of writing tests against Polysemy. It tests the same things, but in a slightly more reusable way, notably:
withActiveUserfor building those parametersignoringStateto dramatically reduce the typing burdenChecklist
changelog.d