Skip to content

Comments

nit-picks#2761

Merged
fisx merged 6 commits intodevelopfrom
debug-spar
Oct 25, 2022
Merged

nit-picks#2761
fisx merged 6 commits intodevelopfrom
debug-spar

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 11, 2022

small nit-picks and docs improvements. doesn't require a changelog entry, i think.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx temporarily deployed to cachix October 11, 2022 10:32 Inactive
@fisx fisx temporarily deployed to cachix October 11, 2022 10:32 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 11, 2022
@fisx fisx temporarily deployed to cachix October 24, 2022 08:36 Inactive
@fisx fisx marked this pull request as ready for review October 24, 2022 08:36
@fisx fisx changed the title Cleanup, debug spar nit-picks Oct 24, 2022
@fisx
Copy link
Contributor Author

fisx commented Oct 24, 2022

feel free to merge if everything is ready.

@echo -e ">>> see https://github.com/wireapp/wire-server/blob/develop/docs/developer/building.md#linker-errors-while-compiling\n\n\n"
@echo -e ">>> try 'git submodule update --init --recursive' and 'make full-clean' and run your command again."
@echo -e ">>> see https://github.com/wireapp/wire-server/blob/develop/docs/developer/building.md#linker-errors-while-compiling"
@echo -e ">>> to never have to remember submodules again, try `git config --global submodule.recurse true`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@fisx fisx temporarily deployed to cachix October 24, 2022 12:17 Inactive
@fisx fisx temporarily deployed to cachix October 24, 2022 19:06 Inactive
@fisx fisx temporarily deployed to cachix October 24, 2022 19:15 Inactive
@fisx fisx temporarily deployed to cachix October 25, 2022 15:04 Inactive
@fisx fisx merged commit 8d031a9 into develop Oct 25, 2022
@fisx fisx deleted the debug-spar branch October 25, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants