Conversation
zebot
added
the
ok-to-test
fisx
force-pushed
the
fisx/servantify-stern-2
branch
from
c899023 to
fe5698c
Compare
fisx
force-pushed
the
fisx/servantify-stern-2
branch
from
fe5698c to
69a2437
Compare
elland
force-pushed
the
fisx/servantify-stern-2
branch
from
73672d8 to
9b7f614
Compare
elland
reviewed
Oct 6, 2022
tools/stern/src/Stern/Types.hs
Outdated
Contributor
There was a problem hiding this comment.
We usually do Data.Schema unqualified and qualify Data.Swagger as S, having it like this makes things a bit confusing to read at first, because of the expectations being violated.
…rn-2' into fisx/servantify-stern-2
elland
approved these changes
Oct 6, 2022
Contributor
elland
left a comment
elland
left a comment
There was a problem hiding this comment.
LGTM, worked on my machine (oops).
Contributor
Author
|
I have double-checked that we don't expose any of the new routes via |
Contributor
Author
|
ci failure looks unrelated, merging now! |
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SEC-202
#2742
Checklist
changelog.d