Skip to content

Comments

charts/wire-server-metrics: drop#2740

Merged
flokli merged 1 commit intodevelopfrom
drop-wire-server-metrics-chart
Oct 11, 2022
Merged

charts/wire-server-metrics: drop#2740
flokli merged 1 commit intodevelopfrom
drop-wire-server-metrics-chart

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Sep 30, 2022

This seems to have gotten broken, it complains about some resources that can't be found:

level=error ts=2022-09-30T08:09:08.703284478Z caller=klog.go:116 component=k8s_client_runtime func=ErrorDepth msg="status \"default/wire-server-metrics-kube-p-prometheus\" failed: failed to update status subresource: prometheuses.monitoring.coreos.com \"wire-server-metrics-kube-p-prometheus\" not found"

Describing how to install a monitoring system, shipping our own wrapper chart, and documenting how to install it shouldn't be something we did in first place. It's a potential endless game of whack-a-mole with upstream changes, and mirroring it downstream in our documentation shouldn't be part of wire-server.

Instead, describe what wire-server can do, how it marks its metrics endpoints via ServiceMonitor, and refer to the upstream docs of two commonly used metrics operators.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@flokli flokli temporarily deployed to cachix September 30, 2022 08:41 Inactive
@flokli flokli temporarily deployed to cachix September 30, 2022 08:41 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 30, 2022
This seems to have gotten broken, it complains about some resources that
can't be found:

```
level=error ts=2022-09-30T08:09:08.703284478Z caller=klog.go:116 component=k8s_client_runtime func=ErrorDepth msg="status \"default/wire-server-metrics-kube-p-prometheus\" failed: failed to update status subresource: prometheuses.monitoring.coreos.com \"wire-server-metrics-kube-p-prometheus\" not found"
```

Describing how to install a monitoring system, shipping our own wrapper
chart, and documenting how to install it shouldn't be something we did
in first place. It's a potential endless game of whack-a-mole with
upstream changes, and mirroring it downstream in our documentation
shouldn't be part of wire-server.

Instead, describe what wire-server can do, how it marks its metrics
endpoints via ServiceMonitor, and refer to the upstream docs of two
commonly used metrics operators.
@flokli flokli force-pushed the drop-wire-server-metrics-chart branch from 466ed38 to 7bc4e84 Compare October 1, 2022 08:14
@flokli flokli temporarily deployed to cachix October 1, 2022 08:14 Inactive
@flokli flokli temporarily deployed to cachix October 1, 2022 08:14 Inactive
@amitsagtani97
Copy link
Contributor

I used https://prometheus-operator.dev/docs/prologue/quick-start instead of kube-prometheus-stack chart to run the wire-server-metrics and it worked fine for me.
As compared to previous configs -
I had to create a Prometheus datasource and upload dashboards manually.

@flokli
Copy link
Contributor Author

flokli commented Oct 4, 2022

I used https://prometheus-operator.dev/docs/prologue/quick-start instead of kube-prometheus-stack chart to run the wire-server-metrics and it worked fine for me.

Thanks for the report! Nice to hear it worked for you!

As compared to previous configs - I had to create a Prometheus datasource and upload dashboards manually.

That's documented in https://github.com/wireapp/wire-server/pull/2740/files#diff-cdd6ec92e849a7c32afdb1f9e79c0fc8195f86a9cbfbb2ce52dd892e66306251R20-R21

@flokli flokli merged commit 031060f into develop Oct 11, 2022
@flokli flokli deleted the drop-wire-server-metrics-chart branch October 11, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants