Skip to content

Comments

Update nginz and cannon ACLs to match api-versioned paths#2725

Merged
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/update-acl
Sep 26, 2022
Merged

Update nginz and cannon ACLs to match api-versioned paths#2725
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/update-acl

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 23, 2022

This PR updates the ACL files to include api-versioned paths (paths prefixed by v2/, etc).

This PR makes use of the new regex syntax in libzauth that was introduced in #2714

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix September 23, 2022 09:56 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 23, 2022 09:56 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 23, 2022
@smatting smatting force-pushed the pcapriotti/update-acl branch from efc637c to d933637 Compare September 23, 2022 11:33
@smatting smatting temporarily deployed to cachix September 23, 2022 11:33 Inactive
@smatting smatting temporarily deployed to cachix September 23, 2022 11:33 Inactive
@smatting smatting changed the title Update nginz whitelists and blacklists Update nginz and cannon ACLs Sep 23, 2022
@smatting smatting changed the title Update nginz and cannon ACLs Update nginz and cannon ACLs to match api-versioned paths Sep 23, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since cannon only have the /await route there is no need to include other rules

@smatting smatting marked this pull request as ready for review September 23, 2022 11:39
@smatting smatting self-requested a review September 23, 2022 11:40
@smatting smatting temporarily deployed to cachix September 23, 2022 11:42 Inactive
@smatting smatting temporarily deployed to cachix September 23, 2022 11:42 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/update-acl branch from 5504cef to 68c0f8b Compare September 26, 2022 07:34
@pcapriotti pcapriotti temporarily deployed to cachix September 26, 2022 07:34 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 26, 2022 07:35 Inactive
@pcapriotti pcapriotti merged commit e6ed1e6 into develop Sep 26, 2022
@pcapriotti pcapriotti deleted the pcapriotti/update-acl branch September 26, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants