Skip to content

Comments

JCT-147: update SCIM documentation how to deactivate user#2720

Merged
fisx merged 3 commits intowireapp:developfrom
Veki301:scim_deactivate_user
Sep 26, 2022
Merged

JCT-147: update SCIM documentation how to deactivate user#2720
fisx merged 3 commits intowireapp:developfrom
Veki301:scim_deactivate_user

Conversation

@Veki301
Copy link
Contributor

@Veki301 Veki301 commented Sep 22, 2022

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@Veki301 Veki301 temporarily deployed to cachix September 22, 2022 09:57 Inactive
@Veki301 Veki301 temporarily deployed to cachix September 22, 2022 09:57 Inactive
Copy link
Contributor

@arthurwolf arthurwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add a changelog file under changelog.d/4-docs/pr-2720 that contains just the string "Document user deactivation (aka suspension) with SCIM."?

I would do it myself, but it's your fork. :)

Co-authored-by: fisx <mf@zerobuzz.net>
@Veki301 Veki301 temporarily deployed to cachix September 26, 2022 09:14 Inactive
@Veki301 Veki301 temporarily deployed to cachix September 26, 2022 09:14 Inactive
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments.

@Veki301 Veki301 temporarily deployed to cachix September 26, 2022 09:23 Inactive
@Veki301 Veki301 temporarily deployed to cachix September 26, 2022 09:23 Inactive
@Veki301
Copy link
Contributor Author

Veki301 commented Sep 26, 2022

@fisx added changelog, please merge once checks are done, thank you :)

@fisx fisx merged commit 4d03923 into wireapp:develop Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants