[SQSERVICES-1643] Servantify brig account API 7 - POST /password-reset/:key#2705
Merged
battermann merged 7 commits intodevelopfrom Sep 23, 2022
Conversation
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
from
05b56dc to
efb5403
Compare
zebot
added
the
ok-to-test
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
from
efb5403 to
43c22b6
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
from
43c22b6 to
152d3e0
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
from
11eff7d to
14b181f
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
from
4ce295f to
3e26053
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
from
c7063d6 to
a06b3a2
Compare
Base automatically changed from
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
to
develop
September 23, 2022 07:06
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
from
8665f08 to
b344410
Compare
fisx
requested changes
Sep 23, 2022
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
I like the changes in Wire.API.User.Password! But the end-point either needs to be fixed or rolled back. Your call!
| :> CanThrow 'ResetPasswordMustDiffer | ||
| :> Description "DEPRECATED: Use 'POST /password-reset/complete'." | ||
| :> "password-reset" | ||
| :> QueryParam' '[Required, Strict, Description "An opaque key for a pending password reset."] "key" PasswordResetKey |
Contributor
There was a problem hiding this comment.
Caption, not QueryParam.
Now I'm concerned about there not be any tests that cover this change, though. Maybe better leave this one alone until we remove it?
fisx
approved these changes
Sep 23, 2022
battermann
deleted the
SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1643
Checklist
changelog.d