[SQSERVICES-1643] Servantify brig account API 2 - GET /activate#2700
Merged
battermann merged 3 commits intodevelopfrom Sep 20, 2022
Merged
Conversation
4e811eb to
01a355c
Compare
GET /activate
GET /activateGET /activate
GET /activateGET /activate
fisx
approved these changes
Sep 19, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| <*> activatedFirst Schema..= (fromMaybe False <$> Schema.optFieldWithDocModifier "first" (description ?~ "Whether this is the first successful activation (i.e. account activation).") Schema.schema) | |
| <*> activatedFirst Schema..= (fromMaybe False <$> Schema.optFieldWithDocModifier "first" (description ?~ "Whether this is the first successful activation of this account.") Schema.schema) |
(Not sure I understand, though. How often can one account be activated successfully?)
Contributor
Author
There was a problem hiding this comment.
This is from the original swagger documentation. IMO it should not be changed in this PR. Also it is not obvious to me either how this should be phrased correctly.
services/brig/src/Brig/API/Public.hs
Outdated
Contributor
There was a problem hiding this comment.
(functionNameH traditionally means "functionName, but there is a servant handler with that name, and this is just the wrapper with the wai-route plumbing in it; will be removed once we switch to servant". So it's probably/usually a good idea to merge the two, but yes, in this case I'm not sure how to do that off the top of my head.)
dfdd1d6 to
776df23
Compare
860ab66 to
035d17d
Compare
776df23 to
ea4975a
Compare
Base automatically changed from
SQSERVICES-1643-backend-servantify-brig-account-api-1-delete
to
develop
September 20, 2022 13:17
added docs for ActivationResponse
ca38058 to
665bb3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1643
Checklist
changelog.d